azurerm_kubernetes_cluster - gate node_os_channel_upgrade check since it's a preview feature
#22284
Conversation
|
@stephybun according to the last AKS release notes it's only the |
|
@stevehipwell yes I saw this in the docs and unfortunately that behaviour is not what I observed for the version that we're currently on which is From the release notes it looks like that behaviour applies from the versions |
|
@stephybun setting |
|
@stevehipwell setting default values on fields is problematic in AKS since they aren't usually returned by the API until they've been explicitly set by the user. This is compounded by the fact that this is also a preview feature so the default value could change from version to version which would then constitute a breaking change in the provider. This feature is actually a great example of that since the msft docs currently states
But the changelog says
Since we cannot move to either of those versions yet, we believe this fix is the least disruptive way to expose it until we're able to upgrade the API version in the provider. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Due to the nature of the feature we had to add in some fairly stringent validation to prevent users from ending up with config that diverged from state.
But the validation currently also prevents clusters from being created even if the preview feature isn't enabled. This rearranges the validation to not interfere with users not wishing to use the preview feature.